Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix known issues #1213

Merged
merged 5 commits into from
Oct 19, 2019
Merged

Fix known issues #1213

merged 5 commits into from
Oct 19, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Oct 15, 2019 •
edited by stevenjoezhang
Loading

Issue resolved: #1213

@theme-next theme-next locked as spam and limited conversation to collaborators Oct 15, 2019
@1v9 1v9 closed this Oct 15, 2019
@1v9 1v9 deleted the 1v9-patch-1 branch October 15, 2019 01:26
@stevenjoezhang stevenjoezhang restored the 1v9-patch-1 branch October 18, 2019 17:50
@theme-next theme-next unlocked this conversation Oct 18, 2019
@stevenjoezhang stevenjoezhang changed the title Update exturl.js Migrate to Nunjucks [4] Oct 18, 2019
@stevenjoezhang stevenjoezhang added this to the v7.5.0 milestone Oct 18, 2019
@stevenjoezhang stevenjoezhang changed the title Migrate to Nunjucks [4] Fix known issues Oct 19, 2019
@stevenjoezhang stevenjoezhang mentioned this pull request Oct 19, 2019
Closed
4 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Oct 19, 2019
Merged
@stevenjoezhang
Copy link
Contributor

What's the difference?

@1v9
Copy link
Member Author

1v9 commented Oct 19, 2019

if disable social_icons, will get undefined

@stevenjoezhang
Revert "update"
e63cf04 
This reverts commit 6cfd6ea.
@stevenjoezhang
Copy link
Contributor

#1219 (comment)

@stevenjoezhang stevenjoezhang merged commit 3d485d8 into master Oct 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1v9-patch-1 branch October 19, 2019 12:51
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9 @stevenjoezhang
Fix known issues (theme-next#1213)
e7e0d6c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

Assignees
No one assigned
Labels
🐞 Bug Fix
Projects
None yet
Milestone
v7.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1v9 @stevenjoezhang